Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add lecture time change #1168

Open
wants to merge 85 commits into
base: dev
Choose a base branch
from
Open

Feature/add lecture time change #1168

wants to merge 85 commits into from

Conversation

mono424
Copy link
Collaborator

@mono424 mono424 commented Sep 21, 2023 •
edited
Loading

Motivation and Context

No possibility to change date and time of a lecture.

Description

  • Added Timing Fields to Lectures
  • Added Logs to changeSet
  • Added Computed Properties

Steps for Testing

Prerequisites:

  • 1 Lecturer
  1. Log in
  2. Navigate to a Course Management Page
  3. Change Date Time of a Lecture
  4. Reload Page
  5. Check if Time Date is still changed
  6. Check if other settings can be changed too.

Screenshots

Bildschirmaufnahme.2023-09-28.um.00.20.11.mov

Bildschirmfoto 2023-09-27 um 22 03 55

@mono424
started wit hrefactor of course management
84d18ee
@mono424
Merge branch 'dev' into improvement/refactor-course-mgmt
eb2fcd7
@mono424
add dao & route
429ad67
@mono424
update route
d1ea050
@mono424
started wit hfetching
8aa4d69
@mono424
Add changeset abstraction
db3f3bb
@mono424
cleanup file
0225a59
@mono424
remove get all streams again, as there is AdminJson method
29c0977
@mono424
Its rendering
0f32725
@mono424
further dev :S
797d00d
@mono424
added some directive
17f460a
@mono424
little fixes
ca9c567
@mono424
...
246fa48
@mono424
... no idea...
1e66fc9
@mono424
right path i guess
e36890d
@mono424
changeset working except video sections
fcf15c2
@mono424
fix discard files
e576712
@mono424
save from laptop
c25956a
@mono424
Add changeset doku
5102141
@mono424
make private works like charm
7518b5d
@mono424
changing works pretty well
8416d26
@mono424
add video upload
8afb2b9
@mono424
add series update
f4a005f
@mono424
ported transcoding
a258dc5
@mono424
add readme and lecture hall select
184b0aa
@mono424
more description
81e783d
@mono424
simplified lecture hall set
cffbf3e
@mono424
Merge branch 'dev' into improvement/refactor-course-mgmt
5548883
@mono424
linter
2db8643
@mono424
more fixes
098b2d5
@github-actions
Copy link

Your Testserver will be ready at https://1168.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3		 student1
student2		 student2
student3		 student1
student2

@mono424 mono424 marked this pull request as ready for review September 27, 2023 22:23
@joschahenningsen
Copy link
Member

@mono424 thanks! Do you have time to resolve the conflicts?

@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Sure currently not at a computer but will do today!

@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :)

1 similar comment
@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :)

@mono424
Copy link
Collaborator Author

mono424 commented Oct 18, 2023

@joschahenningsen Any update on this ? :)

@SebiWrn SebiWrn mentioned this pull request Oct 21, 2024
Open
@SebiWrn SebiWrn enabled auto-merge (squash) October 21, 2024 13:12
@SebiWrn SebiWrn disabled auto-merge October 21, 2024 13:13
@alexanderstephan alexanderstephan self-assigned this Oct 30, 2024
@SebiWrn SebiWrn requested a review from a team November 29, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschahenningsen joschahenningsen Awaiting requested review from joschahenningsen

@alexanderstephan alexanderstephan Awaiting requested review from alexanderstephan

At least 1 approving review is required to merge this pull request.

Assignees

@alexanderstephan alexanderstephan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mono424 @joschahenningsen @alexanderstephan